Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 2233913003: Fix errors introduced by recent strong-mode changes (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/cancelable_future.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-10 15:47:05 UTC) #2
scheglov
lgtm
4 years, 4 months ago (2016-08-10 16:10:31 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 38689cd848277a5138dd44317eb0c575c04f550c (presubmit successful).
4 years, 4 months ago (2016-08-10 16:12:54 UTC) #5
Jennifer Messerly
4 years, 4 months ago (2016-08-10 19:39:48 UTC) #7
Message was sent while issue was closed.
LGTM, thanks so much for fixing that!

Powered by Google App Engine
This is Rietveld 408576698