rAc: Scroll to any input that receives keyboard focus

chrome/browser/ui/views/autofill/autofill_dialog_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 1661 matching lines @@
     views::View* focused_before,
     views::View* focused_now) {
   // If user leaves an edit-field, revalidate the group it belongs to.
   if (focused_before) {
     DetailsGroup* group = GroupForView(focused_before);
     if (group && group->container->visible())
       ValidateGroup(*group, VALIDATE_EDIT);
   }
 
   // Show an error bubble when the user focuses the input.
-  if (focused_now)
+  if (focused_now) {
+    focused_now->ScrollRectToVisible(focused_now->GetLocalBounds());
     ShowErrorBubbleForViewIfNecessary(focused_now);
+  }
 }
 
 void AutofillDialogViews::OnSelectedIndexChanged(views::Combobox* combobox) {
   DetailsGroup* group = GroupForView(combobox);
   ValidateGroup(*group, VALIDATE_EDIT);
 }
 
 void AutofillDialogViews::StyledLabelLinkClicked(const ui::Range& range,
                                                  int event_flags) {
   delegate_->LegalDocumentLinkClicked(range);
@@ skipping 314 matching lines @@
       validity_map_.erase(input);
       error_bubble_.reset();
     }
   }
 }
 
 void AutofillDialogViews::ShowErrorBubbleForViewIfNecessary(views::View* view) {
   if (!view->GetWidget())
     return;
 
-  if (error_bubble_ && error_bubble_->anchor() == view)
-    return;
-
   std::map<views::View*, base::string16>::iterator error_message =
       validity_map_.find(view);
   if (error_message != validity_map_.end()) {
     view->ScrollRectToVisible(view->GetLocalBounds());
-    error_bubble_.reset(new ErrorBubble(view, error_message->second));
+
+    if (!error_bubble_ || error_bubble_->anchor() != view)
+      error_bubble_.reset(new ErrorBubble(view, error_message->second));
   }
 }
 
 void AutofillDialogViews::MarkInputsInvalid(DialogSection section,
                                             const ValidityData& validity_data) {
   DetailsGroup* group = GroupForSection(section);
   DCHECK(group->container->visible());
 
   typedef std::map<ServerFieldType,
       base::Callback<void(const base::string16&)> > FieldMap;
@@ skipping 244 matching lines @@
 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
     : section(section),
       container(NULL),
       manual_input(NULL),
       suggested_info(NULL),
       suggested_button(NULL) {}
 
 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
 
 }  // namespace autofill