GN: Mark all variables used when defining a template.

GN: Mark all variables used when defining a template.

This exempts file-scoped values from used variable checking when a template is
defined. This avoids spurious unused variable warnings at the expense of
potentially missing unused variables in some cases. These warnings have tripped
people up multiple times.

The potential for missing actual unused values is pretty small, however,
because most templates are defined in .gni files that don't have used variable
checking (since they could be included into many different contexts).

BUG=395883
Committed: https://crrev.com/ba1286d0e720ef723192e4a2af7e99d0516495d6
Cr-Commit-Position: refs/heads/master@{#411265}

[brettw, 2016-08-10 21:23:29]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2016-08-10 21:23:34]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-10 21:31:18]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-10 21:31:18]

Does this address crbug.com/618866 as well?

[brettw, 2016-08-10 21:32:17]

That's the same bug, I duped it.

[scottmg, 2016-08-10 21:56:33]

lgtm with test added

[commit-bot: I haz the power, 2016-08-10 22:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:04:24]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-08-10 22:48:48]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-10 22:48:49]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2233893005/#ps20001
(title: "tests")

[commit-bot: I haz the power, 2016-08-10 22:50:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-11 00:08:45]

lgtm

[commit-bot: I haz the power, 2016-08-11 01:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:50:38]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-08-11 03:22:49]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:23:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:33:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 05:08:09]

Description was changed from

==========
GN: Mark all variables used when defining a template.

This exempts file-scoped values from used variable checking when a template is
defined. This avoids spurious unused variable warnings at the expense of
potentially missing unused variables in some cases. These warnings have tripped
people up multiple times.

The potential for missing actual unused values is pretty small, however,
because most templates are defined in .gni files that don't have used variable
checking (since they could be included into many different contexts).

BUG=395883
==========

to

==========
GN: Mark all variables used when defining a template.

This exempts file-scoped values from used variable checking when a template is
defined. This avoids spurious unused variable warnings at the expense of
potentially missing unused variables in some cases. These warnings have tripped
people up multiple times.

The potential for missing actual unused values is pretty small, however,
because most templates are defined in .gni files that don't have used variable
checking (since they could be included into many different contexts).

BUG=395883

Committed: https://crrev.com/ba1286d0e720ef723192e4a2af7e99d0516495d6
Cr-Commit-Position: refs/heads/master@{#411265}
==========

[commit-bot: I haz the power, 2016-08-11 05:08:10]

Patchset 2 (id:??) landed as
https://crrev.com/ba1286d0e720ef723192e4a2af7e99d0516495d6
Cr-Commit-Position: refs/heads/master@{#411265}