Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2233893002: [battor agent] Don't log all bytes received when reading sample frames (Closed)

Created:
4 years, 4 months ago by charliea (OOO until 10-5)
Modified:
4 years, 4 months ago
Reviewers:
aschulman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[battor agent] Don't log all bytes received when reading sample frames This logging mode exacerbates problems on Mac wherein we drop sample frames because the serial buffer overflows from not processing frames fast enough. TBR=aschulman@chromium.org BUG=636167 Committed: https://crrev.com/4a4dbdadd4632038295e2e5133b7f3a162c78f27 Cr-Commit-Position: refs/heads/master@{#411047}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M tools/battor_agent/battor_connection_impl.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233893002/20001
4 years, 4 months ago (2016-08-10 14:25:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-10 15:50:28 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a4dbdadd4632038295e2e5133b7f3a162c78f27 Cr-Commit-Position: refs/heads/master@{#411047}
4 years, 4 months ago (2016-08-10 15:52:01 UTC) #9
aschulman
4 years, 4 months ago (2016-08-10 23:15:00 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698