Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Why is this configurable if we can't work without it?

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?


BUG=skia:5617
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002

Committed: https://skia.googlesource.com/skia/+/3d96cb8db71895ff1e34d537774f94a578fcec49

[mtklein_C, 2016-08-10 13:47:30]

Description was changed from

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?

BUG=skia:
==========

to

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002
==========

[mtklein_C, 2016-08-10 13:48:01]

Description was changed from

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002
==========

to

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Why is this configurable if we can't work without it?

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002
==========

[mtklein_C, 2016-08-10 13:48:27]

mtklein@chromium.org changed reviewers:
+ bsalomon@google.com

[mtklein_C, 2016-08-10 13:48:28]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-10 13:48:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-10 13:48:40]

Description was changed from

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Why is this configurable if we can't work without it?

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002
==========

to

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Why is this configurable if we can't work without it?

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?


BUG=skia:5617
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002
==========

[commit-bot: I haz the power, 2016-08-10 13:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 13:50:02]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bsalomon, 2016-08-10 14:17:32]

lgtm.

The native OpenGL functions on Windows are always __stdcall regardless of
compiler.

Now that we actually store std::functions rather than function pointers, I'd
like to localize this to the code that loads windows function pointers into
Ganesh's std::function table. But that's a bigger change for another day.

[mtklein, 2016-08-10 14:29:14]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-10 14:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:30:23]

Description was changed from

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Why is this configurable if we can't work without it?

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?


BUG=skia:5617
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002
==========

to

==========
Default GR_GL_FUNCTION_TYPE to __stdcall on Windows.

Why is this configurable if we can't work without it?

Just to confirm, this is a Windows constraint, not an MSVC constraint, right?
Clang on Windows also needs __stdcall?


BUG=skia:5617
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233883002

Committed:
https://skia.googlesource.com/skia/+/3d96cb8db71895ff1e34d537774f94a578fcec49
==========

[commit-bot: I haz the power, 2016-08-10 14:30:27]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3d96cb8db71895ff1e34d537774f94a578fcec49