Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 223383003: DCHECK fix: don't call a given callback twice in ServiceWorkerContextCore (Closed)

Created:
6 years, 8 months ago by kinuko
Modified:
6 years, 8 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

DCHECK fix: don't call a given callback twice in ServiceWorkerContextCore Another DCHECK fix. Very simple error, without this 'return' we call the callback twice which hits assertion in the receiver side in the renderer. BUG=359438 TEST=manually tested with non-existent service-worker URL in debug build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
Yet another simple DCHECK error... can you take a look? (sorry for no tests)
6 years, 8 months ago (2014-04-03 07:31:40 UTC) #1
falken
lgtm
6 years, 8 months ago (2014-04-03 07:34:01 UTC) #2
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 8 months ago (2014-04-03 07:36:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/223383003/1
6 years, 8 months ago (2014-04-03 07:37:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 12:19:25 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 12:19:26 UTC) #6
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 8 months ago (2014-04-03 15:34:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/223383003/1
6 years, 8 months ago (2014-04-03 15:35:00 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:44:21 UTC) #9
Message was sent while issue was closed.
Change committed as 261446

Powered by Google App Engine
This is Rietveld 408576698