test/cctest/test-heap-profiler.cc - Issue 223383002: Return MaybeHandle from NewConsString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 223383002: Return MaybeHandle from NewConsString. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 56c81defb4853d497ddc3528b5779e1d3b60cbff..c38af93f3039dcabed574b76df3b247f61ca7e04 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -445,7 +445,8 @@ TEST(HeapSnapshotConsString) {

factory->NewStringFromAscii(i::CStrVector("0123456789"));

i::Handle<i::String> second =

factory->NewStringFromAscii(i::CStrVector("0123456789"));

- i::Handle<i::String> cons_string = factory->NewConsString(first, second);

+ i::Handle<i::String> cons_string =

+ factory->NewConsString(first, second).ToHandleChecked();

global->SetInternalField(0, v8::ToApiHandle<v8::String>(cons_string));

« no previous file with comments | « src/uri.h ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »