Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/factory.h

Issue 223383002: Return MaybeHandle from NewConsString. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FACTORY_H_ 5 #ifndef V8_FACTORY_H_
6 #define V8_FACTORY_H_ 6 #define V8_FACTORY_H_
7 7
8 #include "isolate.h" 8 #include "isolate.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 // characters of the string are uninitialized. Currently used in regexp code 133 // characters of the string are uninitialized. Currently used in regexp code
134 // only, where they are pretenured. 134 // only, where they are pretenured.
135 Handle<SeqOneByteString> NewRawOneByteString( 135 Handle<SeqOneByteString> NewRawOneByteString(
136 int length, 136 int length,
137 PretenureFlag pretenure = NOT_TENURED); 137 PretenureFlag pretenure = NOT_TENURED);
138 Handle<SeqTwoByteString> NewRawTwoByteString( 138 Handle<SeqTwoByteString> NewRawTwoByteString(
139 int length, 139 int length,
140 PretenureFlag pretenure = NOT_TENURED); 140 PretenureFlag pretenure = NOT_TENURED);
141 141
142 // Create a new cons string object which consists of a pair of strings. 142 // Create a new cons string object which consists of a pair of strings.
143 Handle<String> NewConsString(Handle<String> left, 143 MUST_USE_RESULT MaybeHandle<String> NewConsString(Handle<String> left,
144 Handle<String> right); 144 Handle<String> right);
145 145
146 Handle<ConsString> NewRawConsString(String::Encoding encoding); 146 Handle<ConsString> NewRawConsString(String::Encoding encoding);
147 147
148 // Create a new sequential string containing the concatenation of the inputs. 148 // Create a new sequential string containing the concatenation of the inputs.
149 Handle<String> NewFlatConcatString(Handle<String> first, 149 Handle<String> NewFlatConcatString(Handle<String> first,
150 Handle<String> second); 150 Handle<String> second);
151 151
152 // Create a new string object which holds a proper substring of a string. 152 // Create a new string object which holds a proper substring of a string.
153 Handle<String> NewProperSubString(Handle<String> str, 153 Handle<String> NewProperSubString(Handle<String> str,
154 int begin, 154 int begin,
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 Handle<String> message); 426 Handle<String> message);
427 427
428 Handle<Object> NewTypeError(const char* message, 428 Handle<Object> NewTypeError(const char* message,
429 Vector< Handle<Object> > args); 429 Vector< Handle<Object> > args);
430 Handle<Object> NewTypeError(Handle<String> message); 430 Handle<Object> NewTypeError(Handle<String> message);
431 431
432 Handle<Object> NewRangeError(const char* message, 432 Handle<Object> NewRangeError(const char* message,
433 Vector< Handle<Object> > args); 433 Vector< Handle<Object> > args);
434 Handle<Object> NewRangeError(Handle<String> message); 434 Handle<Object> NewRangeError(Handle<String> message);
435 435
436 Handle<Object> NewInvalidStringLengthError() {
437 return NewRangeError("invalid_string_length",
438 HandleVector<Object>(NULL, 0));
439 }
440
436 Handle<Object> NewSyntaxError(const char* message, Handle<JSArray> args); 441 Handle<Object> NewSyntaxError(const char* message, Handle<JSArray> args);
437 Handle<Object> NewSyntaxError(Handle<String> message); 442 Handle<Object> NewSyntaxError(Handle<String> message);
438 443
439 Handle<Object> NewReferenceError(const char* message, 444 Handle<Object> NewReferenceError(const char* message,
440 Vector< Handle<Object> > args); 445 Vector< Handle<Object> > args);
441 Handle<Object> NewReferenceError(const char* message, Handle<JSArray> args); 446 Handle<Object> NewReferenceError(const char* message, Handle<JSArray> args);
442 Handle<Object> NewReferenceError(Handle<String> message); 447 Handle<Object> NewReferenceError(Handle<String> message);
443 448
444 Handle<Object> NewEvalError(const char* message, 449 Handle<Object> NewEvalError(const char* message,
445 Vector< Handle<Object> > args); 450 Vector< Handle<Object> > args);
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 594
590 // Update the map cache in the native context with (keys, map) 595 // Update the map cache in the native context with (keys, map)
591 Handle<MapCache> AddToMapCache(Handle<Context> context, 596 Handle<MapCache> AddToMapCache(Handle<Context> context,
592 Handle<FixedArray> keys, 597 Handle<FixedArray> keys,
593 Handle<Map> map); 598 Handle<Map> map);
594 }; 599 };
595 600
596 } } // namespace v8::internal 601 } } // namespace v8::internal
597 602
598 #endif // V8_FACTORY_H_ 603 #endif // V8_FACTORY_H_
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698