Issue 223383002: Return MaybeHandle from NewConsString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223383002: Return MaybeHandle from NewConsString. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Return MaybeHandle from NewConsString. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20473

Patch Set 2 : addressed comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -88 lines)			Patch
M	src/api.cc	View		2 chunks	+7 lines, -8 lines	0 comments	Download
M	src/factory.h	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/func-name-inferrer.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/isolate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-stringifier.h	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View		5 chunks	+50 lines, -43 lines	0 comments	Download
M	src/uri.h	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-strings.cc	View		11 chunks	+25 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/223383002/diff/1/src/factory.h File src/factory.h (right): https://codereview.chromium.org/223383002/diff/1/src/factory.h#newcode436 src/factory.h:436: Handle<Object> NewInvalidStringError() { I would ...

6 years, 8 months ago (2014-04-03 09:41:25 UTC) #2

Yang

6 years, 8 months ago (2014-04-03 11:38:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20473 (presubmit successful).

Expand Messages | Collapse Messages

Issue 223383002: Return MaybeHandle from NewConsString. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages