Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2233783002: Cleanup budget_database based on evolving API. (Closed)

Created:
4 years, 4 months ago by harkness
Modified:
4 years, 4 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup budget_database based on evolving API. Removed debt, which is no longer needed. Added data structures to replace the std::pairs. Switched the storage of expiration time from a double to an int. BUG=617971 Committed: https://crrev.com/bf8b3854f94e3ef3c367c361efdbd64784f9bc92 Cr-Commit-Position: refs/heads/master@{#411100}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated comments and added emplace_ usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -54 lines) Patch
M chrome/browser/budget_service/budget.proto View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/budget_service/budget_database.h View 1 4 chunks +32 lines, -9 lines 0 comments Download
M chrome/browser/budget_service/budget_database.cc View 1 6 chunks +19 lines, -24 lines 0 comments Download
M chrome/browser/budget_service/budget_database_unittest.cc View 5 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
harkness
4 years, 4 months ago (2016-08-10 11:05:47 UTC) #2
harkness
4 years, 4 months ago (2016-08-10 11:16:22 UTC) #6
Peter Beverloo
lgtm https://codereview.chromium.org/2233783002/diff/1/chrome/browser/budget_service/budget_database.cc File chrome/browser/budget_service/budget_database.cc (right): https://codereview.chromium.org/2233783002/diff/1/chrome/browser/budget_service/budget_database.cc#newcode75 chrome/browser/budget_service/budget_database.cc:75: budget_map_[origin.spec()].push_back(BudgetChunk(amount, expiration)); nit: could rewrite this as: budget_map_[origin.spec()].emplace_back(amount, ...
4 years, 4 months ago (2016-08-10 15:36:45 UTC) #9
harkness
https://codereview.chromium.org/2233783002/diff/1/chrome/browser/budget_service/budget_database.cc File chrome/browser/budget_service/budget_database.cc (right): https://codereview.chromium.org/2233783002/diff/1/chrome/browser/budget_service/budget_database.cc#newcode75 chrome/browser/budget_service/budget_database.cc:75: budget_map_[origin.spec()].push_back(BudgetChunk(amount, expiration)); On 2016/08/10 15:36:44, Peter Beverloo wrote: > ...
4 years, 4 months ago (2016-08-10 16:41:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233783002/20001
4 years, 4 months ago (2016-08-10 16:42:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 18:42:24 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:47:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf8b3854f94e3ef3c367c361efdbd64784f9bc92
Cr-Commit-Position: refs/heads/master@{#411100}

Powered by Google App Engine
This is Rietveld 408576698