Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2233763003: [polymer] - Sort series data before adding to legend. (Closed)

Created:
4 years, 4 months ago by shatch
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M dashboard/dashboard/elements/chart-container.html View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
shatch
4 years, 4 months ago (2016-08-10 18:09:18 UTC) #1
aiolos (Not reviewing)
lgtm
4 years, 4 months ago (2016-08-10 18:26:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233763003/1
4 years, 4 months ago (2016-08-10 18:35:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/76ba893246e3a5331793b91278d0aeb3b3c16313
4 years, 4 months ago (2016-08-10 19:06:44 UTC) #6
aiolos (Not reviewing)
4 years, 3 months ago (2016-08-30 23:34:21 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2294873003/ by aiolos@chromium.org.

The reason for reverting is: This sorts the legend, but not the underlying graph
data. It's leading to miss-matches between what people select and what graphs
get shown.

BUG=catapult:#2701.

Powered by Google App Engine
This is Rietveld 408576698