Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2233753003: Revert of Show the status area widget in mash (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show the status area widget in mash (patchset #1 id:1 of https://codereview.chromium.org/2230083002/ ) Reason for revert: This doesn't work due to ash_sysui no longer running https://codereview.chromium.org/2235493002/. I'm going to revert and land a patch that works. Original issue's description: > Show the status area widget in mash > > This code will need to change when ShelfLayoutManager is working in mash, but > for now it gets something on the screen. > > BUG=615155, 621112 > TEST=none > > Committed: https://crrev.com/c5513e3d979bd1eecb221405a1fae007f38ae3c2 > Cr-Commit-Position: refs/heads/master@{#411046} TBR=msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615155, 621112 Committed: https://crrev.com/7025b343bb1a6bdf97242a09c10e6b0633a140f4 Cr-Commit-Position: refs/heads/master@{#411051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ash/mus/root_window_controller.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
James Cook
Created Revert of Show the status area widget in mash
4 years, 4 months ago (2016-08-10 16:27:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233753003/1
4 years, 4 months ago (2016-08-10 16:28:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 16:29:25 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:31:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7025b343bb1a6bdf97242a09c10e6b0633a140f4
Cr-Commit-Position: refs/heads/master@{#411051}

Powered by Google App Engine
This is Rietveld 408576698