Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2233753002: pdf: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

pdf: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 TBR=gene@chromium.org Committed: https://crrev.com/5c1cf727b9ec3b191018b6041b53d5e9704fe957 Cr-Commit-Position: refs/heads/master@{#411616}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 16:55:58 UTC) #7
Sami
TBR'ing since this is a mechanical patch.
4 years, 4 months ago (2016-08-12 12:30:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233753002/20001
4 years, 4 months ago (2016-08-12 12:31:37 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 12:35:37 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:37:33 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c1cf727b9ec3b191018b6041b53d5e9704fe957
Cr-Commit-Position: refs/heads/master@{#411616}

Powered by Google App Engine
This is Rietveld 408576698