Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2233733002: third_party/crashpad: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai, scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/crashpad: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/c611e28afd32908c01118c57c5c17f47ad2c7519 Cr-Commit-Position: refs/heads/master@{#411680}

Patch Set 1 #

Patch Set 2 : Mac/Win fixes #

Patch Set 3 : Rebased #

Patch Set 4 : Updated README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/crashpad/README.chromium View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_handle_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_body.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/pointer_container.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 16:42:10 UTC) #7
scottmg
Thanks. Could you please also update third_party/crashpad/README.chromium pointing to this change? (And optionally apply this ...
4 years, 4 months ago (2016-08-10 20:12:27 UTC) #9
Sami
On 2016/08/10 20:12:27, scottmg wrote: > Thanks. Could you please also update third_party/crashpad/README.chromium > pointing ...
4 years, 4 months ago (2016-08-12 12:01:44 UTC) #14
scottmg
Thanks, lgtm.
4 years, 4 months ago (2016-08-12 16:24:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233733002/60001
4 years, 4 months ago (2016-08-12 16:31:21 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-12 17:10:16 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:12:16 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c611e28afd32908c01118c57c5c17f47ad2c7519
Cr-Commit-Position: refs/heads/master@{#411680}

Powered by Google App Engine
This is Rietveld 408576698