Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2233693002: Storage manager: Fix font size and adjust layout. (Closed)

Created:
4 years, 4 months ago by fukino
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Fix font size and adjust layout. In the previous layout spec, the font size looks too big compared to other parts in Settings. This CL adjust the font size and some layout. The spec is https://drive.google.com/corp/drive/u/0/folders/0B_2Uyb2Rhx2OWkdMM2tJanUxdjg BUG=636224 TEST=confirmed manually on minnie. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3f134220f879b3ec4a29d985ac94c10c7b82524c Cr-Commit-Position: refs/heads/master@{#411260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M chrome/browser/resources/options/chromeos/storage_manager.css View 1 chunk +18 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.html View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fukino
PTAL. Thanks!
4 years, 4 months ago (2016-08-10 06:48:13 UTC) #3
Dan Beam
lgtm
4 years, 4 months ago (2016-08-11 00:17:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233693002/1
4 years, 4 months ago (2016-08-11 02:33:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 04:08:24 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 04:10:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f134220f879b3ec4a29d985ac94c10c7b82524c
Cr-Commit-Position: refs/heads/master@{#411260}

Powered by Google App Engine
This is Rietveld 408576698