Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2233683003: extract content_browsertest WebRtcConstraintsBrowserTest into its own file (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract content_browsertest WebRtcConstraintsBrowserTest into its own file The original file is too large, and files are cheap. Also, said WebRtcConstraintsBrowserTest will need beefing up soon as the new constraint grammar(s) are being introduced. No new coded added, just shoveling code around. BUG=633257 Committed: https://crrev.com/0a976e3faaa9d37acd126b901809d5cc4fc78f98 Cr-Commit-Position: refs/heads/master@{#411317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -64 lines) Patch
A content/browser/webrtc/webrtc_constraints_browsertest.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mcasas
ehmaldonado@ PTAL tommi@ Owner RS plz
4 years, 4 months ago (2016-08-10 16:12:56 UTC) #2
ehmaldonado_chromium
On 2016/08/10 16:12:56, mcasas wrote: > ehmaldonado@ PTAL > > tommi@ Owner RS plz lgtm
4 years, 4 months ago (2016-08-11 07:14:29 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 4 months ago (2016-08-11 11:03:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233683003/1
4 years, 4 months ago (2016-08-11 13:21:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 13:57:56 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 13:59:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a976e3faaa9d37acd126b901809d5cc4fc78f98
Cr-Commit-Position: refs/heads/master@{#411317}

Powered by Google App Engine
This is Rietveld 408576698