Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2233663002: Fix the location of resources in iOS frameworks. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the location of resources in iOS frameworks. On iOS, the resources for an application and a framework bundle are located in the root of the bundle (as opposed to macOS where they are located in the Resources sub-directory). The incorrect location caused code signature failure (when code signature is enabled, which is only the case on downstream iOS bots). BUG=635302 Committed: https://crrev.com/3cbe1a432673431822494cca4b8d662eca112d72 Cr-Commit-Position: refs/heads/master@{#410984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/ios/rules.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sdefresne
Proper fix, ptal!
4 years, 4 months ago (2016-08-10 05:08:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233663002/1
4 years, 4 months ago (2016-08-10 05:10:04 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-10 05:10:08 UTC) #6
justincohen
lgtm
4 years, 4 months ago (2016-08-10 05:11:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233663002/1
4 years, 4 months ago (2016-08-10 05:11:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 06:45:29 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:47:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cbe1a432673431822494cca4b8d662eca112d72
Cr-Commit-Position: refs/heads/master@{#410984}

Powered by Google App Engine
This is Rietveld 408576698