Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/analysis_server/lib/src/services/search/hierarchy.dart

Issue 2233633003: Convert to async/await parts that cause strong mode warnings. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/search/hierarchy.dart
diff --git a/pkg/analysis_server/lib/src/services/search/hierarchy.dart b/pkg/analysis_server/lib/src/services/search/hierarchy.dart
index b6e1c9e4fb35c4068d8e73885722df0504641358..1822f1baa0861eae73972438a53c541d3906cf6c 100644
--- a/pkg/analysis_server/lib/src/services/search/hierarchy.dart
+++ b/pkg/analysis_server/lib/src/services/search/hierarchy.dart
@@ -58,15 +58,9 @@ List<Element> getClassMembers(ClassElement clazz, [String name]) {
* Returns a [Set] with direct subclasses of [seed].
*/
Future<Set<ClassElement>> getDirectSubClasses(
- SearchEngine searchEngine, ClassElement seed) {
- return searchEngine.searchSubtypes(seed).then((List<SearchMatch> matches) {
- Set<ClassElement> subClasses = new HashSet<ClassElement>();
- for (SearchMatch match in matches) {
- ClassElement subClass = match.element;
- subClasses.add(subClass);
- }
- return subClasses;
- });
+ SearchEngine searchEngine, ClassElement seed) async {
+ List<SearchMatch> matches = await searchEngine.searchSubtypes(seed);
+ return matches.map((match) => match.element).toSet();
}
/**
@@ -74,7 +68,7 @@ Future<Set<ClassElement>> getDirectSubClasses(
* their subclasses.
*/
Future<Set<ClassMemberElement>> getHierarchyMembers(
- SearchEngine searchEngine, ClassMemberElement member) {
+ SearchEngine searchEngine, ClassMemberElement member) async {
Set<ClassMemberElement> result = new HashSet<ClassMemberElement>();
// static elements
if (member.isStatic || member is ConstructorElement) {
@@ -84,7 +78,6 @@ Future<Set<ClassMemberElement>> getHierarchyMembers(
// method, field, etc
String name = member.displayName;
ClassElement memberClass = member.enclosingElement;
- List<Future> futures = <Future>[];
Set<ClassElement> searchClasses = getSuperClasses(memberClass);
searchClasses.add(memberClass);
for (ClassElement superClass in searchClasses) {
@@ -93,23 +86,19 @@ Future<Set<ClassMemberElement>> getHierarchyMembers(
continue;
}
// check all sub- classes
- var subClassFuture = getSubClasses(searchEngine, superClass);
- var membersFuture = subClassFuture.then((Set<ClassElement> subClasses) {
- subClasses.add(superClass);
- for (ClassElement subClass in subClasses) {
- List<Element> subClassMembers = getChildren(subClass, name);
- for (Element member in subClassMembers) {
- if (member is ClassMemberElement) {
- result.add(member);
- }
+ Set<ClassElement> subClasses =
+ await getSubClasses(searchEngine, superClass);
+ subClasses.add(superClass);
+ for (ClassElement subClass in subClasses) {
+ List<Element> subClassMembers = getChildren(subClass, name);
+ for (Element member in subClassMembers) {
+ if (member is ClassMemberElement) {
+ result.add(member);
}
}
- });
- futures.add(membersFuture);
+ }
}
- return Future.wait(futures).then((_) {
- return result;
- });
+ return result;
}
/**
@@ -133,15 +122,9 @@ List<Element> getMembers(ClassElement clazz) {
* Returns a [Set] with all direct and indirect subclasses of [seed].
*/
Future<Set<ClassElement>> getSubClasses(
- SearchEngine searchEngine, ClassElement seed) {
- return searchEngine.searchAllSubtypes(seed).then((List<SearchMatch> matches) {
- Set<ClassElement> ancestors = new HashSet<ClassElement>();
- for (SearchMatch match in matches) {
- ClassElement ancestor = match.element;
- ancestors.add(ancestor);
- }
- return ancestors;
- });
+ SearchEngine searchEngine, ClassElement seed) async {
+ List<SearchMatch> matches = await searchEngine.searchAllSubtypes(seed);
+ return matches.map((match) => match.element).toSet();
}
/**
@@ -167,8 +150,8 @@ Set<ClassElement> getSuperClasses(ClassElement seed) {
}
}
// append interfaces
- for (InterfaceType intf in current.interfaces) {
- queue.add(intf.element);
+ for (InterfaceType interface in current.interfaces) {
+ queue.add(interface.element);
}
}
// we don't need "seed" itself
« no previous file with comments | « pkg/analysis_server/lib/src/search/type_hierarchy.dart ('k') | pkg/analysis_server/test/edit/refactoring_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698