Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2233633003: Convert to async/await parts that cause strong mode warnings. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert to async/await parts that cause strong mode warnings. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0522cad42a4d296d41ce8b06d7db6c867e2da796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -310 lines) Patch
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 1 chunk +34 lines, -35 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/hierarchy.dart View 6 chunks +19 lines, -36 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +5 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 33 chunks +132 lines, -198 lines 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 1 chunk +8 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 2 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-10 17:11:16 UTC) #1
Brian Wilkerson
lgtm I like the changes regardless, but I'm surprised because none of these were producing ...
4 years, 4 months ago (2016-08-10 17:18:45 UTC) #2
scheglov
4 years, 4 months ago (2016-08-10 17:28:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0522cad42a4d296d41ce8b06d7db6c867e2da796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698