Issue 2233633002: Switch dartium to @patch annotation from patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2233633002: Switch dartium to @patch annotation from patch. (Closed)

Created:
4 years, 4 months ago by Jacob

Modified:
4 years, 4 months ago

Reviewers:
terry, siva

CC:
reviews_dartlang.org, siva

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Switch to @patch annotation from patch. BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/b77967972184caa289db3ade13ff44b6c65bb103

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+667 lines, -667 lines)			Patch
	M	sdk/lib/js/dartium/cached_patches.dart	View		662 chunks	+662 lines, -662 lines	0 comments	Download
	M	sdk/lib/js/dartium/js_dartium.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

Committed patchset #1 (id:1) manually as b77967972184caa289db3ade13ff44b6c65bb103 (presubmit successful).

4 years, 4 months ago (2016-08-10 16:31:13 UTC) #5

siva

4 years, 4 months ago (2016-08-10 20:00:12 UTC) #7

Message was sent while issue was closed.

Another minor change was done for the patch syntax
https://codereview.chromium.org/2230383003/
(accepting the @patch annotation instead of in comments).
Not sure if that would effect the generator.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages