Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2233613002: [Android] Remove vestigial isolate_file logic from instrumentation_test_apk. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove vestigial isolate_file logic from instrumentation_test_apk. BUG=633333 Committed: https://crrev.com/982ede9f8a7d63f5986110e673b3d4cfaa50fcb6 Cr-Commit-Position: refs/heads/master@{#413536}

Patch Set 1 #

Patch Set 2 : Remove unused gypi_to_gn invocation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/config/android/rules.gni View 1 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jbudorick
blocked on one last downstream CL
4 years, 4 months ago (2016-08-10 01:58:38 UTC) #2
agrieve
lgtm
4 years, 4 months ago (2016-08-10 02:36:16 UTC) #3
jbudorick
Downstream CL landed, so I'm landing this.
4 years, 4 months ago (2016-08-22 15:57:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233613002/20001
4 years, 4 months ago (2016-08-22 15:58:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/266032)
4 years, 4 months ago (2016-08-22 18:36:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233613002/20001
4 years, 4 months ago (2016-08-22 20:03:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 21:20:04 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:21:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/982ede9f8a7d63f5986110e673b3d4cfaa50fcb6
Cr-Commit-Position: refs/heads/master@{#413536}

Powered by Google App Engine
This is Rietveld 408576698