Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: content/renderer/input/main_thread_event_queue.cc

Issue 2233543002: Make first TouchStart and first TouchMove events on a flinging layer non-blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/main_thread_event_queue.cc
diff --git a/content/renderer/input/main_thread_event_queue.cc b/content/renderer/input/main_thread_event_queue.cc
index bc0fac27a04a573968c2fe49984a474078b7652c..6a38ca2607844f4facda40e60f9751d1de3e1689 100644
--- a/content/renderer/input/main_thread_event_queue.cc
+++ b/content/renderer/input/main_thread_event_queue.cc
@@ -41,6 +41,9 @@ MainThreadEventQueue::MainThreadEventQueue(
: routing_id_(routing_id),
client_(client),
is_flinging_(false),
+ last_touch_start_forced_nonblocking_due_to_fling_(false),
+ enable_fling_passive_listener_flag_(base::FeatureList::IsEnabled(
+ features::kPassiveEventListenersDueToFling)),
main_task_runner_(main_task_runner) {}
MainThreadEventQueue::~MainThreadEventQueue() {}
@@ -57,10 +60,6 @@ bool MainThreadEventQueue::HandleEvent(
bool non_blocking = original_dispatch_type == DISPATCH_TYPE_NON_BLOCKING ||
ack_result == INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING;
-
- InputEventDispatchType dispatch_type =
- non_blocking ? DISPATCH_TYPE_NON_BLOCKING : DISPATCH_TYPE_BLOCKING;
-
bool is_wheel = event->type == blink::WebInputEvent::MouseWheel;
bool is_touch = blink::WebInputEvent::isTouchEventType(event->type);
@@ -74,6 +73,21 @@ bool MainThreadEventQueue::HandleEvent(
touch_event->dispatchType =
blink::WebInputEvent::ListenersNonBlockingPassive;
}
+ if (touch_event->type == blink::WebInputEvent::TouchStart)
+ last_touch_start_forced_nonblocking_due_to_fling_ = false;
+
+ if (enable_fling_passive_listener_flag_ &&
+ touch_event->touchStartOrFirstTouchMove &&
+ touch_event->dispatchType == blink::WebInputEvent::Blocking) {
+ // If the touch start is forced to be passive due to fling, its following
+ // touch move should also be passive.
+ if (is_flinging_ || last_touch_start_forced_nonblocking_due_to_fling_) {
+ touch_event->dispatchType =
+ blink::WebInputEvent::ListenersForcedNonBlockingDueToFling;
+ non_blocking = true;
+ last_touch_start_forced_nonblocking_due_to_fling_ = true;
+ }
+ }
}
if (is_wheel && non_blocking) {
// Adjust the |dispatchType| on the event since the compositor
@@ -82,6 +96,8 @@ bool MainThreadEventQueue::HandleEvent(
->dispatchType = blink::WebInputEvent::ListenersNonBlockingPassive;
}
+ InputEventDispatchType dispatch_type =
+ non_blocking ? DISPATCH_TYPE_NON_BLOCKING : DISPATCH_TYPE_BLOCKING;
std::unique_ptr<EventWithDispatchType> event_with_dispatch_type(
new EventWithDispatchType(std::move(event), latency, dispatch_type));
« no previous file with comments | « content/renderer/input/main_thread_event_queue.h ('k') | content/renderer/input/main_thread_event_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698