Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/renderer/input/input_event_filter_unittest.cc

Issue 2233543002: Make first TouchStart and first TouchMove events on a flinging layer non-blocking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set non_blocking to true Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_event_filter_unittest.cc
diff --git a/content/renderer/input/input_event_filter_unittest.cc b/content/renderer/input/input_event_filter_unittest.cc
index e4ac4b41db70e5f58c547c014d215d8848335b22..4abfdcf4f076fa6bc0cfb89487e9d6155e340bb3 100644
--- a/content/renderer/input/input_event_filter_unittest.cc
+++ b/content/renderer/input/input_event_filter_unittest.cc
@@ -404,6 +404,7 @@ TEST_F(InputEventFilterTest, NonBlockingTouch) {
EXPECT_EQ(kEvents[i].size, event->size);
kEvents[i].dispatchType =
WebInputEvent::DispatchType::ListenersNonBlockingPassive;
+ kEvents[i].touchStartOrFirstTouchMove = true;
EXPECT_TRUE(memcmp(&kEvents[i], event, event->size) == 0);
EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING,
dispatch_type);
@@ -461,6 +462,7 @@ TEST_F(InputEventFilterTest, IntermingledNonBlockingTouch) {
EXPECT_EQ(kEvents[0].size, event->size);
kEvents[0].dispatchType =
WebInputEvent::DispatchType::ListenersNonBlockingPassive;
+ kEvents[0].touchStartOrFirstTouchMove = true;
EXPECT_TRUE(memcmp(&kEvents[0], event, event->size) == 0);
EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING,
dispatch_type);
@@ -477,6 +479,7 @@ TEST_F(InputEventFilterTest, IntermingledNonBlockingTouch) {
EXPECT_EQ(kEvents[1].size, event->size);
kEvents[1].dispatchType =
WebInputEvent::DispatchType::ListenersNonBlockingPassive;
+ kEvents[1].touchStartOrFirstTouchMove = false;
EXPECT_TRUE(memcmp(&kEvents[1], event, event->size) == 0);
EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_NON_BLOCKING,
dispatch_type);
@@ -489,7 +492,7 @@ TEST_F(InputEventFilterTest, IntermingledNonBlockingTouch) {
EXPECT_TRUE(InputMsg_HandleInputEvent::Read(&message, &params));
const WebInputEvent* event = std::get<0>(params);
InputEventDispatchType dispatch_type = std::get<2>(params);
-
+ kBlockingEvents[0].touchStartOrFirstTouchMove = true;
EXPECT_EQ(kBlockingEvents[0].size, event->size);
EXPECT_TRUE(memcmp(&kBlockingEvents[0], event, event->size) == 0);
EXPECT_EQ(InputEventDispatchType::DISPATCH_TYPE_BLOCKING, dispatch_type);

Powered by Google App Engine
This is Rietveld 408576698