Issue 2233513002: [mapToVisualRectInAncestorSpace] Check for detached iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2233513002: [mapToVisualRectInAncestorSpace] Check for detached iframes. (Closed)

Created:
4 years, 4 months ago by szager1

Modified:
4 years, 4 months ago

Reviewers:
chrishtr, Xianzhu

CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

[mapToVisualRectInAncestorSpace] Check for detached iframes. If, e.g., display:none is set on an iframe, mapTo... should return an empty rect. Merged from https://codereview.chromium.org/2218703002 BUG=627616 TBR=chrishtr@chromium.org,wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	third_party/WebKit/Source/core/layout/LayoutView.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233513002/1

4 years, 4 months ago (2016-08-09 20:20:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages