Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2233493003: [Offline Pages] Remove expired requests from the queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merging. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index f548563f03a0675d7d2aeaad973932ae6da89b41..97d7826dc93089e1ed74dfe39db6e6a04965860d 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -128,6 +128,14 @@ class RequestCoordinator : public KeyedService {
void RemoveObserver(RequestCoordinator::Observer* observer);
+ // Send a notification of the |request| to observers via coordinator.
+ void NotifyAdded(const SavePageRequest& request);
+ void NotifySucceeded(const SavePageRequest& request);
+ virtual void NotifyFailed(const SavePageRequest& request,
+ SavePageStatus status);
+ void NotifyChanged(const SavePageRequest& request);
+ void NotifyRemoved(const SavePageRequest& request);
Pete Williamson 2016/08/16 23:40:46 FYI: You'll need to do another merge soon, these a
romax 2016/08/17 20:07:58 Done.
+
// Returns the request queue used for requests. Coordinator keeps ownership.
RequestQueue* queue() { return queue_.get(); }
@@ -191,12 +199,6 @@ class RequestCoordinator : public KeyedService {
void TryNextRequest();
- void NotifyAdded(const SavePageRequest& request);
- void NotifySucceeded(const SavePageRequest& request);
- void NotifyFailed(const SavePageRequest& request, SavePageStatus status);
- void NotifyChanged(const SavePageRequest& request);
- void NotifyRemoved(const SavePageRequest& request);
-
// Returns the appropriate offliner to use, getting a new one from the factory
// if needed.
void GetOffliner();

Powered by Google App Engine
This is Rietveld 408576698