Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2233493003: [Offline Pages] Remove expired requests from the queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing patching error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index 5c6c03ba07193c4a779da7d6ea1d0ead94cf177e..1822deceb3f4c418559fa163833089f3a35664a1 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -80,6 +80,12 @@ class RequestCoordinator : public KeyedService {
const Scheduler::TriggerConditions GetTriggerConditionsForUserRequest();
+ // Notifies the observers that |expired_requests| have been expired and
+ // removed from the queue, along with the |result|.
+ virtual void NotifyRequestsExpired(
Pete Williamson 2016/08/10 17:15:11 We will use the existing NotifyFailed for this. N
romax 2016/08/16 23:20:56 Done.
+ const std::vector<SavePageRequest>& expired_requests,
+ RequestQueue::UpdateRequestResult result);
+
// A way for tests to set the callback in use when an operation is over.
void SetProcessingCallbackForTest(const base::Callback<void(bool)> callback) {
scheduler_callback_ = callback;

Powered by Google App Engine
This is Rietveld 408576698