Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2233493002: Put patch syntax warning behind a flag (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Put patch syntax warning behind a flag Fixes Dartium tests, which choke on the additional output introduced by the warning. TBR=vegorov Committed: https://github.com/dart-lang/sdk/commit/f56654e8820cd130120d90891b73ece8110c315a

Patch Set 1 #

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M runtime/vm/parser.cc View 1 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 4 months ago (2016-08-09 19:57:17 UTC) #3
hausner
Committed patchset #2 (id:20001) manually as f56654e8820cd130120d90891b73ece8110c315a (presubmit successful).
4 years, 4 months ago (2016-08-09 20:01:17 UTC) #5
Vyacheslav Egorov (Google)
4 years, 4 months ago (2016-08-09 20:03:59 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698