Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: src/parsing/parser.h

Issue 2233473002: Redirect most NewUnresolved calls over Parser (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.h ('k') | src/parsing/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index 1648700d2aaa931a3b4f6e00c44dc8bf63db3e09..d9550f223dc364858500a84b8a347937e498b8f9 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -549,17 +549,15 @@ class ParserTraits {
const AstRawString* GetNextSymbol(Scanner* scanner);
const AstRawString* GetNumberAsSymbol(Scanner* scanner);
- Expression* ThisExpression(AstNodeFactory* factory,
- int pos = kNoSourcePosition);
+ Expression* ThisExpression(int pos);
Expression* NewSuperPropertyReference(AstNodeFactory* factory, int pos);
Expression* NewSuperCallReference(AstNodeFactory* factory, int pos);
- Expression* NewTargetExpression(AstNodeFactory* factory, int pos);
+ Expression* NewTargetExpression(int pos);
Expression* FunctionSentExpression(AstNodeFactory* factory, int pos);
Literal* ExpressionFromLiteral(Token::Value token, int pos, Scanner* scanner,
AstNodeFactory* factory);
Expression* ExpressionFromIdentifier(const AstRawString* name,
- int start_position, int end_position,
- AstNodeFactory* factory);
+ int start_position, int end_position);
Expression* ExpressionFromString(int pos, Scanner* scanner,
AstNodeFactory* factory);
Expression* GetIterator(Expression* iterable, AstNodeFactory* factory,
@@ -1086,7 +1084,10 @@ class Parser : public ParserBase<ParserTraits> {
bool* ok);
static InitializationFlag DefaultInitializationFlag(VariableMode mode);
- VariableProxy* NewUnresolved(const AstRawString* name, VariableMode mode);
+ VariableProxy* NewUnresolved(const AstRawString* name, int begin_pos,
+ int end_pos = kNoSourcePosition,
+ Variable::Kind kind = Variable::NORMAL);
+ VariableProxy* NewUnresolved(const AstRawString* name);
Variable* Declare(Declaration* declaration,
DeclarationDescriptor::Kind declaration_kind,
VariableMode mode, InitializationFlag init, bool* ok,
« no previous file with comments | « src/ast/scopes.h ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698