Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/parsing/pattern-rewriter.cc

Issue 2233473002: Redirect most NewUnresolved calls over Parser (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parsing/parser-base.h ('k') | src/parsing/preparser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/ast.h" 5 #include "src/ast/ast.h"
6 #include "src/messages.h" 6 #include "src/messages.h"
7 #include "src/parsing/parameter-initializer-rewriter.h" 7 #include "src/parsing/parameter-initializer-rewriter.h"
8 #include "src/parsing/parser.h" 8 #include "src/parsing/parser.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 // an initial value in the declaration (because they are initialized upon 140 // an initial value in the declaration (because they are initialized upon
141 // entering the function). 141 // entering the function).
142 // 142 //
143 // If we have a legacy const declaration, in an inner scope, the proxy 143 // If we have a legacy const declaration, in an inner scope, the proxy
144 // is always bound to the declared variable (independent of possibly 144 // is always bound to the declared variable (independent of possibly
145 // surrounding 'with' statements). 145 // surrounding 'with' statements).
146 // For let/const declarations in harmony mode, we can also immediately 146 // For let/const declarations in harmony mode, we can also immediately
147 // pre-resolve the proxy because it resides in the same scope as the 147 // pre-resolve the proxy because it resides in the same scope as the
148 // declaration. 148 // declaration.
149 const AstRawString* name = pattern->raw_name(); 149 const AstRawString* name = pattern->raw_name();
150 VariableProxy* proxy = parser_->NewUnresolved(name, descriptor_->mode); 150 VariableProxy* proxy = descriptor_->scope->NewUnresolved(
151 factory(), name, parser_->scanner()->location().beg_pos,
152 parser_->scanner()->location().end_pos);
151 Declaration* declaration = factory()->NewVariableDeclaration( 153 Declaration* declaration = factory()->NewVariableDeclaration(
152 proxy, descriptor_->scope, descriptor_->declaration_pos); 154 proxy, descriptor_->scope, descriptor_->declaration_pos);
153 Variable* var = parser_->Declare(declaration, descriptor_->declaration_kind, 155 Variable* var = parser_->Declare(declaration, descriptor_->declaration_kind,
154 descriptor_->mode, 156 descriptor_->mode,
155 DefaultInitializationFlag(descriptor_->mode), 157 DefaultInitializationFlag(descriptor_->mode),
156 ok_, descriptor_->hoist_scope); 158 ok_, descriptor_->hoist_scope);
157 if (!*ok_) return; 159 if (!*ok_) return;
158 DCHECK_NOT_NULL(var); 160 DCHECK_NOT_NULL(var);
159 DCHECK(proxy->is_resolved()); 161 DCHECK(proxy->is_resolved());
160 DCHECK(initializer_position_ != kNoSourcePosition); 162 DCHECK(initializer_position_ != kNoSourcePosition);
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 NOT_A_PATTERN(TryFinallyStatement) 702 NOT_A_PATTERN(TryFinallyStatement)
701 NOT_A_PATTERN(UnaryOperation) 703 NOT_A_PATTERN(UnaryOperation)
702 NOT_A_PATTERN(VariableDeclaration) 704 NOT_A_PATTERN(VariableDeclaration)
703 NOT_A_PATTERN(WhileStatement) 705 NOT_A_PATTERN(WhileStatement)
704 NOT_A_PATTERN(WithStatement) 706 NOT_A_PATTERN(WithStatement)
705 NOT_A_PATTERN(Yield) 707 NOT_A_PATTERN(Yield)
706 708
707 #undef NOT_A_PATTERN 709 #undef NOT_A_PATTERN
708 } // namespace internal 710 } // namespace internal
709 } // namespace v8 711 } // namespace v8
OLDNEW
« no previous file with comments | « src/parsing/parser-base.h ('k') | src/parsing/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698