Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2233403003: [turbofan] Eliminate redundant elements kind transitions. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate redundant elements kind transitions. A TransitionElementsKind operation is redundant if we already know that the object has the target_map (independent of what the source_map might be). R=yangguo@chromium.org Committed: https://crrev.com/e6e32315ccf7d30b1c8a7946f9940e4aaf2fe9c7 Cr-Commit-Position: refs/heads/master@{#38597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/compiler/load-elimination.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-12 05:52:23 UTC) #1
Yang
On 2016/08/12 05:52:23, Benedikt Meurer wrote: lgtm.
4 years, 4 months ago (2016-08-12 06:36:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233403003/1
4 years, 4 months ago (2016-08-12 06:50:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 06:52:24 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 06:52:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6e32315ccf7d30b1c8a7946f9940e4aaf2fe9c7
Cr-Commit-Position: refs/heads/master@{#38597}

Powered by Google App Engine
This is Rietveld 408576698