Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2233393002: [turbofan] Some strength reduction for ConvertTaggedHoleToUndefined. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Some strength reduction for ConvertTaggedHoleToUndefined. We can fold ConvertTaggedHoleToUndefined into CheckNumber and CheckTaggedSigned, as they deoptimize no matter if the input is undefined or hole. R=jarin@chromium.org Committed: https://crrev.com/7ada01689958fc2a5a7029f5244463f56385fd50 Cr-Commit-Position: refs/heads/master@{#38576}

Patch Set 1 #

Patch Set 2 : Fix redness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-11 10:54:27 UTC) #1
Jarin
lgtm
4 years, 4 months ago (2016-08-11 10:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233393002/1
4 years, 4 months ago (2016-08-11 10:59:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/2223) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-11 11:08:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233393002/20001
4 years, 4 months ago (2016-08-11 12:02:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 12:49:46 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 12:50:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ada01689958fc2a5a7029f5244463f56385fd50
Cr-Commit-Position: refs/heads/master@{#38576}

Powered by Google App Engine
This is Rietveld 408576698