Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2233303002: Correctly increment crashed renderer process stability counts on OOM. (Closed)

Created:
4 years, 4 months ago by Will Harris
Modified:
4 years, 4 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly increment crashed renderer process stability counts on OOM. Change the code to use a switch statement to detect changes to enum in future. Add tests. BUG=636541 TEST=components_unittests Committed: https://crrev.com/1633bec645f94fa0681eeccf7704491b336489a8 Cr-Commit-Position: refs/heads/master@{#411519}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : add android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -39 lines) Patch
M components/metrics/stability_metrics_helper.cc View 1 2 1 chunk +55 lines, -37 lines 0 comments Download
M components/metrics/stability_metrics_helper_unittest.cc View 1 7 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Will Harris
PTAL. Thanks!
4 years, 4 months ago (2016-08-11 19:39:49 UTC) #3
rkaplow
lgtm thanks!
4 years, 4 months ago (2016-08-11 19:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233303002/20001
4 years, 4 months ago (2016-08-11 19:53:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/121058)
4 years, 4 months ago (2016-08-11 20:09:49 UTC) #8
Will Harris
On 2016/08/11 20:09:49, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-11 20:31:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233303002/60001
4 years, 4 months ago (2016-08-12 00:59:51 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-12 02:07:40 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 02:10:12 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1633bec645f94fa0681eeccf7704491b336489a8
Cr-Commit-Position: refs/heads/master@{#411519}

Powered by Google App Engine
This is Rietveld 408576698