chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h - Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 2233293003: Position Mac permission bubbles on the left when in fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix MacViews bubbles Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

index c9a2a58c32caa66f9a5ffe6c95882f9fe5d07ab5..99edfff599e82865b3f0e164b4a3da01bc4208c6 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

@@ -42,6 +42,10 @@ class PermissionRequest;

// Returns true if |browser| has a visible location bar.

+ (bool)hasVisibleLocationBarForBrowser:(Browser*)browser;

+// Returns the constant offset from the left to use for fullscreen permission

+// bubbles. Only used in tests.

++ (NSInteger)getFullscreenLeftOffset;

tapted 2016/08/12 04:25:39 you can move this to `@interface PermissionBubbleC

benwells 2016/08/12 06:29:44 Done.

// Makes the bubble visible. The bubble will be popuplated with text retrieved

// from |requests|. |delegate| will receive callbacks for user actions.

- (void)showWithDelegate:(PermissionPrompt::Delegate*)delegate