net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py - Issue 2233233002: Refactor some certificate verification tests in preparation to adding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py

Issue 2233233002: Refactor some certificate verification tests in preparation to adding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trust_anchor

Patch Set: moar Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/data/verify_certificate_chain_unittest/common.py ('K') | « net/data/verify_certificate_chain_unittest/generate-intermediate-basic-constraints-not-critical.py ('k') | net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-signing-key-usage.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py b/net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py

index db91ff72b3ea7b71a336af4bcf70518a08cb85ac..05738035ba702f0d553e2b6c2b4a6057cd53763d 100755

--- a/net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py

+++ b/net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py

@@ -9,7 +9,7 @@ lacks the basic constraints extension, and hence is expected to fail validation

import common

-# Self-signed root certificate (part of trust store).

+# Self-signed root certificate (used as trust anchor).

root = common.create_self_signed_root_certificate('Root')

# Intermediate that lacks basic constraints.

@@ -19,9 +19,12 @@ intermediate.get_extensions().remove_property('basicConstraints')

# Target certificate.

target = common.create_end_entity_certificate('Target', intermediate)

-chain = [target, intermediate]

-trusted = [root]

-time = common.DEFAULT_TIME

-verify_result = False

+# Write the test chain to a file.

+test = common.TestData()

+test.description = __doc__

+test.chain = [target, intermediate]

+test.trust_anchor = common.TrustAnchor(root, constrained=False)

+test.utc_time = common.DEFAULT_TIME

+test.verify_result = False

-common.write_test_file(__doc__, chain, trusted, time, verify_result)

+test.write_to_file(common.get_default_pem_path())