net/cert/internal/verify_certificate_chain_unittest.cc - Issue 2233233002: Refactor some certificate verification tests in preparation to adding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/verify_certificate_chain_unittest.cc

Issue 2233233002: Refactor some certificate verification tests in preparation to adding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trust_anchor

Patch Set: moar Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/test_helpers.cc ('K') | « net/cert/internal/verify_certificate_chain_typed_unittest.h ('k') | net/data/verify_certificate_chain_unittest/README » ('j') | net/data/verify_certificate_chain_unittest/README » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/verify_certificate_chain_unittest.cc

diff --git a/net/cert/internal/verify_certificate_chain_unittest.cc b/net/cert/internal/verify_certificate_chain_unittest.cc

index d886148ea8356759ce894741c8166c3532475150..225dcabcade525cea223e9c38dbc955534600566 100644

--- a/net/cert/internal/verify_certificate_chain_unittest.cc

+++ b/net/cert/internal/verify_certificate_chain_unittest.cc

@@ -15,15 +15,14 @@ namespace {

class VerifyCertificateChainDelegate {

public:

static void Verify(const ParsedCertificateList& chain,

- const TrustAnchors& anchors,

+ const scoped_refptr<TrustAnchor>& trust_anchor,

const der::GeneralizedTime& time,

bool expected_result) {

- ASSERT_EQ(1U, anchors.size());

- ASSERT_TRUE(anchors.front().get());

+ ASSERT_TRUE(trust_anchor);

SimpleSignaturePolicy signature_policy(1024);

- bool result = VerifyCertificateChain(chain, anchors.front().get(),

+ bool result = VerifyCertificateChain(chain, trust_anchor.get(),

&signature_policy, time);

ASSERT_EQ(expected_result, result);