Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2233193002: Pass regenerate-goldens flag through to Java. (Closed)

Created:
4 years, 4 months ago by PEConn
Modified:
4 years, 4 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass regenerate-goldens flag through to Java. BUG=635937 Committed: https://crrev.com/972dd1147691395c2e85d91669e355506ca36141 Cr-Commit-Position: refs/heads/master@{#411322}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Spacing. #

Patch Set 3 : Spacing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
PEConn
PTAL
4 years, 4 months ago (2016-08-10 22:57:43 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/2233193002/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/2233193002/diff/1/build/android/test_runner.py#newcode428 build/android/test_runner.py:428: 'fails or the golden image is ...
4 years, 4 months ago (2016-08-10 23:00:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233193002/40001
4 years, 4 months ago (2016-08-11 14:21:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 14:25:25 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:27:18 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/972dd1147691395c2e85d91669e355506ca36141
Cr-Commit-Position: refs/heads/master@{#411322}

Powered by Google App Engine
This is Rietveld 408576698