Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2233183002: Add gomobile to infra's Go deps, and also roll. (Closed)

Created:
4 years, 4 months ago by bpastene
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Add gomobile to infra's Go deps, and also roll. BUG=632895 Committed: https://chromium.googlesource.com/infra/infra/+/9ba1345173dc384e0f405155341f32b4cc8297ad

Patch Set 1 #

Patch Set 2 : Add gomobile to deps.py whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M go/deps.lock View 7 chunks +17 lines, -12 lines 0 comments Download
M go/deps.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M go/deps.yaml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bpastene
4 years, 4 months ago (2016-08-10 22:50:15 UTC) #2
Vadim Sh.
lgtm
4 years, 4 months ago (2016-08-10 23:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233183002/20001
4 years, 4 months ago (2016-08-11 18:14:08 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 18:28:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/9ba1345173dc384e0f405155341f3...

Powered by Google App Engine
This is Rietveld 408576698