content/browser/indexed_db/leveldb/leveldb_transaction.h - Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_database.cc ('k') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/leveldb/leveldb_transaction.h

diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h

index 91ae38bf98d26c3540c1239f7161c2dcb2b1321d..33392f235336abd55f607ec406250a6c66014113 100644

--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h

+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h

@@ -70,7 +70,8 @@ class CONTENT_EXPORT LevelDBTransaction

const LevelDBComparator* comparator_;

};

- typedef std::map<base::StringPiece, Record*, Comparator> DataType;

+ typedef std::map<base::StringPiece, std::unique_ptr<Record>, Comparator>

+ DataType;

class DataIterator : public LevelDBIterator {

public:

@@ -134,7 +135,6 @@ class CONTENT_EXPORT LevelDBTransaction

};

// Returns true if the key was originally marked deleted, false otherwise.

bool Set(const base::StringPiece& key, std::string* value, bool deleted);

- void Clear();

void RegisterIterator(TransactionIterator* iterator);

void UnregisterIterator(TransactionIterator* iterator);

void NotifyIterators();