content/browser/indexed_db/indexed_db_index_writer.cc - Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_index_writer.cc

Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_factory_unittest.cc ('k') | content/browser/indexed_db/indexed_db_leveldb_coding.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_index_writer.cc

diff --git a/content/browser/indexed_db/indexed_db_index_writer.cc b/content/browser/indexed_db/indexed_db_index_writer.cc

index 2c60d7ed6d2695d6fe8562dfe4004e42c45b9d87..7cf06053ee2a088cea7f3a2cf17dacdfd3f119f4 100644

--- a/content/browser/indexed_db/indexed_db_index_writer.cc

+++ b/content/browser/indexed_db/indexed_db_index_writer.cc

@@ -146,7 +146,8 @@ bool MakeIndexWriters(

if (key_was_generated && (index.key_path == object_store.key_path))

keys.second.push_back(primary_key);

- std::unique_ptr<IndexWriter> index_writer(new IndexWriter(index, keys));

+ std::unique_ptr<IndexWriter> index_writer(

+ base::MakeUnique<IndexWriter>(index, keys));

bool can_add_keys = false;

bool backing_store_success =

index_writer->VerifyIndexKeys(backing_store,