content/browser/indexed_db/indexed_db_backing_store.h - Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_backing_store.h

Issue 2233153002: IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MOAR MakeUnique calls Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc ('k') | content/browser/indexed_db/indexed_db_backing_store.cc » ('j') | content/browser/indexed_db/indexed_db_backing_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_backing_store.h

diff --git a/content/browser/indexed_db/indexed_db_backing_store.h b/content/browser/indexed_db/indexed_db_backing_store.h

index 722a1d4226079b387177ad4f5ed2054febf3b60c..58f699c2236c0e347d65b67ba07c68acc80bf93a 100644

--- a/content/browser/indexed_db/indexed_db_backing_store.h

+++ b/content/browser/indexed_db/indexed_db_backing_store.h

@@ -315,7 +315,7 @@ class CONTENT_EXPORT IndexedDBBackingStore

bool Advance(uint32_t count, leveldb::Status*);

bool FirstSeek(leveldb::Status*);

- virtual Cursor* Clone() = 0;

+ virtual std::unique_ptr<Cursor> Clone() = 0;

cmumford 2016/08/13 00:08:38 Now that you're changing Clone's signature, why no

jsbell 2016/08/16 03:05:28 Done.

virtual const IndexedDBKey& primary_key() const;

virtual IndexedDBValue* value() = 0;

virtual const RecordIdentifier& record_identifier() const;