IndexedDB: WrapUnique(new T(args..)) -> MakeUnique<T>(args...)

content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_MOCK_BROWSERTEST_INDEXED_DB_CLASS_FACTORY_H_
 #define CONTENT_BROWSER_INDEXED_DB_MOCK_BROWSERTEST_INDEXED_DB_CLASS_FACTORY_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 23 matching lines @@
   FAIL_METHOD_COMMIT_DISK_FULL,
   FAIL_METHOD_GET,
   FAIL_METHOD_SEEK,
 };
 
 class MockBrowserTestIndexedDBClassFactory : public IndexedDBClassFactory {
  public:
   MockBrowserTestIndexedDBClassFactory();
   ~MockBrowserTestIndexedDBClassFactory() override;
 
-  IndexedDBDatabase* CreateIndexedDBDatabase(
+  scoped_refptr<IndexedDBDatabase> CreateIndexedDBDatabase(
       const base::string16& name,
       IndexedDBBackingStore* backing_store,
       IndexedDBFactory* factory,
       const IndexedDBDatabase::Identifier& unique_identifier) override;
   IndexedDBTransaction* CreateIndexedDBTransaction(

[cmumford, 2016/08/13 00:08:39]

It'd be nice, in a future commit, to make this a smart pointer too.

[jsbell, 2016/08/16 03:05:28]

Agreed. I was worried about doing it in this patch because it was getting scary
complex already.

[jsbell, 2016/08/16 05:22:18]

To be more precise: this function is WEIRD since (as noted in comments) the
transaction ctor ensures it is "owned" (at least one ref) by the tx coordinator,
so the recipient of the raw pointer never needs to take a ref (and in fact
doesn't). I was worried that there might be some weird case where taking a ref
would delay destruction, so didn't just make the change.

This should probably be untangled a bit, and (like everything in this directory)
we should look for opportunities to eliminate refcounting since it makes
lifetimes more complicated.

       int64_t id,
       base::WeakPtr<IndexedDBConnection> connection,
       const std::set<int64_t>& scope,
       blink::WebIDBTransactionMode mode,
       IndexedDBBackingStore::Transaction* backing_store_transaction) override;
-  LevelDBTransaction* CreateLevelDBTransaction(LevelDBDatabase* db) override;
-  LevelDBIteratorImpl* CreateIteratorImpl(
+  scoped_refptr<LevelDBTransaction> CreateLevelDBTransaction(
+      LevelDBDatabase* db) override;
+  std::unique_ptr<LevelDBIteratorImpl> CreateIteratorImpl(
       std::unique_ptr<leveldb::Iterator> iterator) override;
 
   void FailOperation(FailClass failure_class,
                      FailMethod failure_method,
                      int fail_on_instance_num,
                      int fail_on_call_num);
   void Reset();
 
  private:
   FailClass failure_class_;
   FailMethod failure_method_;
   std::map<FailClass, int> instance_count_;
   std::map<FailClass, int> fail_on_instance_num_;
   std::map<FailClass, int> fail_on_call_num_;
   bool only_trace_calls_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_MOCK_BROWSERTEST_INDEXED_DB_CLASS_FACTORY_H_