Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

Issue 2233123003: Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a double release. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
index 07daf9b470da28dd2841e6c2c8b52b51c1d92e7a..42a4ac38084d3d4f6076863a1441c38cfc8e3f34 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
@@ -17,7 +17,7 @@ class AutocompleteResult;
class OmniboxPopupViewMac;
@interface OmniboxPopupTableController
- : NSViewController<NSTableViewDelegate, NSTableViewDataSource> {
+ : NSObject <NSTableViewDelegate, NSTableViewDataSource> {
Robert Sesek 2016/08/11 15:17:03 nit: no space between NSObject and <
erikchen 2016/08/11 17:47:52 Done.
@private
base::scoped_nsobject<NSArray> array_;
NSInteger hoveredIndex_;

Powered by Google App Engine
This is Rietveld 408576698