chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm - Issue 2233123003: Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Issue 2233123003: Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a double release. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h ('K') | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h » ('j') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

index 4d7bbcc7170325491929fd05950320949c5e943e..7eeb6a86d914a591d4b1984e425ac9ca0e91136a 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

@@ -465,15 +465,12 @@ NSAttributedString* CreateClassifiedAttributedString(

}

maxLines_ = 1;

}

+ propertyReleaser_OmniboxPopupCellData_.Init(self,

+ [OmniboxPopupCellData class]);

}

return self;

}

-- (void)dealloc {

- [incognitoImage_ release];

- [super dealloc];

- (instancetype)copyWithZone:(NSZone*)zone {

return [self retain];

}