components/safe_browsing_db/v4_local_database_manager.h - Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_local_database_manager.h

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring back the histogram to check if there were any hits in the response from the server Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_get_hash_protocol_manager.cc ('K') | « components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc ('k') | components/safe_browsing_db/v4_local_database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_local_database_manager.h

diff --git a/components/safe_browsing_db/v4_local_database_manager.h b/components/safe_browsing_db/v4_local_database_manager.h

index 7fa07fbee4ca5dc95e1ca20b5274d8fede38b3e5..80f0df50be1b2ac507e4f0d119284521327a3e22 100644

--- a/components/safe_browsing_db/v4_local_database_manager.h

+++ b/components/safe_browsing_db/v4_local_database_manager.h

@@ -13,6 +13,7 @@

#include "components/safe_browsing_db/database_manager.h"

#include "components/safe_browsing_db/hit_report.h"

#include "components/safe_browsing_db/v4_database.h"

+#include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"

#include "components/safe_browsing_db/v4_protocol_manager_util.h"

#include "components/safe_browsing_db/v4_update_protocol_manager.h"

#include "url/gurl.h"

@@ -77,6 +78,8 @@ class V4LocalDatabaseManager : public SafeBrowsingDatabaseManager {

void SetupDatabase();

+ void OnFullHashResponse(const std::vector<FullHashInfo>& full_hash_infos);

void DatabaseReady(std::unique_ptr<V4Database> v4_database);

// Called when the database has been updated and schedules the next update.