components/safe_browsing_db/v4_database.cc - Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_database.cc

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring back the histogram to check if there were any hits in the response from the server Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/database_manager_unittest.cc ('K') | « components/safe_browsing_db/v4_database.h ('k') | components/safe_browsing_db/v4_database_unittest.cc » ('j') | components/safe_browsing_db/v4_get_hash_protocol_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_database.cc

diff --git a/components/safe_browsing_db/v4_database.cc b/components/safe_browsing_db/v4_database.cc

index 59bea71a173cbbe51756d6d8333a402e2c1ef61e..3ee7f8d6495776df31b98fc97b316ea0ccc6ea05 100644

--- a/components/safe_browsing_db/v4_database.cc

+++ b/components/safe_browsing_db/v4_database.cc

@@ -171,14 +171,15 @@ std::unique_ptr<StoreStateMap> V4Database::GetStoreStateMap() {

void V4Database::GetStoresMatchingFullHash(

const FullHash& full_hash,

const base::hash_set<UpdateListIdentifier>& stores_to_look,

- MatchedHashPrefixMap* matched_hash_prefix_map) {

+ StoreAndHashPrefixes* matched_store_and_hash_prefixes) {

+ matched_store_and_hash_prefixes->clear();

for (const UpdateListIdentifier& identifier : stores_to_look) {

const auto& store_pair = store_map_->find(identifier);

DCHECK(store_pair != store_map_->end());

const std::unique_ptr<V4Store>& store = store_pair->second;

HashPrefix hash_prefix = store->GetMatchingHashPrefix(full_hash);

if (!hash_prefix.empty()) {

- (*matched_hash_prefix_map)[identifier] = hash_prefix;

+ matched_store_and_hash_prefixes->emplace_back(identifier, hash_prefix);

}