components/safe_browsing_db/v4_store.h - Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_store.h

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove more tests from db_manager. Simplify another test. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_local_database_manager_unittest.cc ('K') | « components/safe_browsing_db/v4_protocol_manager_util.cc ('k') | components/safe_browsing_db/v4_store.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_store.h

diff --git a/components/safe_browsing_db/v4_store.h b/components/safe_browsing_db/v4_store.h

index fc94642d31277f86f30d0684592178c693e331aa..d4559780cae063ccfeae55d8a14f29f33bff8082 100644

--- a/components/safe_browsing_db/v4_store.h

+++ b/components/safe_browsing_db/v4_store.h

@@ -18,10 +18,6 @@ class V4Store;

typedef base::Callback<void(std::unique_ptr<V4Store>)>

UpdatedStoreReadyCallback;

-// The size of the hash prefix, in bytes. It should be between 4 to 32 (full

-// hash).

-typedef size_t PrefixSize;

// The sorted list of hash prefixes.

typedef std::string HashPrefixes;