Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: components/safe_browsing_db/BUILD.gn

Issue 2233103002: Move full hash caching logic to v4_get_hash_protocol_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unique_ptr for V4GetHasProtocolManager. Fix the lone failing unit test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing_db/database_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/BUILD.gn
diff --git a/components/safe_browsing_db/BUILD.gn b/components/safe_browsing_db/BUILD.gn
index f7f58f41ac82cce3c6058c0d727fafa6f7aaec6b..98633a296a8f6f03f61b259760de5fba33c91cec 100644
--- a/components/safe_browsing_db/BUILD.gn
+++ b/components/safe_browsing_db/BUILD.gn
@@ -210,6 +210,7 @@ static_library("v4_local_database_manager") {
":hit_report",
":safebrowsing_proto",
":v4_database",
+ ":v4_get_hash_protocol_manager",
":v4_protocol_manager_util",
":v4_update_protocol_manager",
"//base",
@@ -275,10 +276,61 @@ static_library("v4_update_protocol_manager") {
]
}
+source_set("v4_database_unittest") {
+ testonly = true
+ sources = [
+ "v4_database_unittest.cc",
+ ]
+ deps = [
+ ":v4_database",
+ ":v4_store",
+ "//base",
+ "//base/test:test_support",
+ "//content/test:test_support",
+ "//testing/gtest",
+ ]
+}
+
+source_set("v4_get_hash_protocol_manager_unittest") {
+ testonly = true
+ sources = [
+ "v4_get_hash_protocol_manager_unittest.cc",
+ ]
+ deps = [
+ ":safebrowsing_proto",
+ ":util",
+ ":v4_database",
+ ":v4_get_hash_protocol_manager",
+ ":v4_local_database_manager",
+ "//base",
+ "//base/test:test_support",
+ "//net",
+ "//net:test_support",
+ "//testing/gtest",
+ ]
+}
+
+source_set("v4_local_database_manager_unittest") {
+ testonly = true
+ sources = [
+ "v4_local_database_manager_unittest.cc",
+ ]
+ deps = [
+ ":v4_database",
+ ":v4_local_database_manager",
+ "//base",
+ "//base/test:test_support",
+ "//content/test:test_support",
+ "//net",
+ "//net:test_support",
+ "//testing/gtest",
+ ]
+}
+
source_set("unit_tests") {
testonly = true
sources = [
- "database_manager_unittest.cc",
+ # "database_manager_unittest.cc",
Nathan Parker 2016/09/09 21:26:20 is this staying?
vakh (use Gerrit instead) 2016/09/09 23:25:16 Fixed in a later patch.
"prefix_set_unittest.cc",
"util_unittest.cc",
"v4_database_unittest.cc",
« no previous file with comments | « no previous file | components/safe_browsing_db/database_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698