Move full hash caching logic to v4_get_hash_protocol_manager

components/safe_browsing_db/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/protobuf/proto_library.gni")
 
 proto_library("safebrowsing_proto") {
   sources = [
     "safebrowsing.proto",
   ]
@@ skipping 192 matching lines @@
 static_library("v4_local_database_manager") {
   sources = [
     "v4_local_database_manager.cc",
     "v4_local_database_manager.h",
   ]
   deps = [
     ":database_manager",
     ":hit_report",
     ":safebrowsing_proto",
     ":v4_database",
+    ":v4_get_hash_protocol_manager",
     ":v4_protocol_manager_util",
     ":v4_update_protocol_manager",
     "//base",
     "//content/public/browser",
     "//net",
     "//url",
   ]
 }
 
 source_set("v4_protocol_manager_util") {
@@ skipping 45 matching lines @@
   deps = [
     ":safebrowsing_proto",
     ":util",
     ":v4_protocol_manager_util",
     "//base",
     "//net",
     "//url",
   ]
 }
 
+source_set("v4_database_unittest") {
+  testonly = true
+  sources = [
+    "v4_database_unittest.cc",
+  ]
+  deps = [
+    ":v4_database",
+    ":v4_store",
+    "//base",
+    "//base/test:test_support",
+    "//content/test:test_support",
+    "//testing/gtest",
+  ]
+}
+
+source_set("v4_get_hash_protocol_manager_unittest") {
+  testonly = true
+  sources = [
+    "v4_get_hash_protocol_manager_unittest.cc",
+  ]
+  deps = [
+    ":safebrowsing_proto",
+    ":util",
+    ":v4_database",
+    ":v4_get_hash_protocol_manager",
+    ":v4_local_database_manager",
+    "//base",
+    "//base/test:test_support",
+    "//net",
+    "//net:test_support",
+    "//testing/gtest",
+  ]
+}
+
+source_set("v4_local_database_manager_unittest") {
+  testonly = true
+  sources = [
+    "v4_local_database_manager_unittest.cc",
+  ]
+  deps = [
+    ":v4_database",
+    ":v4_local_database_manager",
+    "//base",
+    "//base/test:test_support",
+    "//content/test:test_support",
+    "//net",
+    "//net:test_support",
+    "//testing/gtest",
+  ]
+}
+
 source_set("unit_tests") {
   testonly = true
   sources = [
-    "database_manager_unittest.cc",
+    #    "database_manager_unittest.cc",

[Nathan Parker, 2016/09/09 21:26:20]

is this staying?

[vakh (use Gerrit instead), 2016/09/09 23:25:16]

Fixed in a later patch.

     "prefix_set_unittest.cc",
     "util_unittest.cc",
     "v4_database_unittest.cc",
     "v4_get_hash_protocol_manager_unittest.cc",
     "v4_local_database_manager_unittest.cc",
     "v4_protocol_manager_util_unittest.cc",
     "v4_rice_unittest.cc",
     "v4_store_unittest.cc",
     "v4_update_protocol_manager_unittest.cc",
   ]
@@ skipping 40 matching lines @@
     "//base",
     "//components/variations",
     "//testing/gtest",
     "//url",
   ]
   if (is_win) {
     # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
     cflags = [ "/wd4267" ]  # Conversion from size_t to 'type'.
   }
 }