Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 22331005: Clean up accessibility enums for use in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: reupload Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index d2509cb753d7578f28b878508367ea087ae96337..250c0c105b4b24a78c5aec841fb03cf2bdff9507 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -127,6 +127,13 @@ static WebAccessibilityNotification toWebAccessibilityNotification(AXObjectCache
return static_cast<WebAccessibilityNotification>(notification);
}
+// Converts a WebCore::AXObjectCache::AXNotification to a WebKit::AXNotification
+static AXNotification toAXNotification(AXObjectCache::AXNotification notification)
+{
+ // These enums have the same values; enforced in AssertMatchingEnums.cpp.
+ return static_cast<AXNotification>(notification);
+}
+
ChromeClientImpl::ChromeClientImpl(WebViewImpl* webView)
: m_webView(webView)
, m_toolbarsVisible(true)
@@ -797,8 +804,10 @@ void ChromeClientImpl::getPopupMenuInfo(PopupContainer* popupContainer,
void ChromeClientImpl::postAccessibilityNotification(AccessibilityObject* obj, AXObjectCache::AXNotification notification)
{
// Alert assistive technology about the accessibility object notification.
- if (obj)
+ if (obj) {
m_webView->client()->postAccessibilityNotification(WebAccessibilityObject(obj), toWebAccessibilityNotification(notification));
+ m_webView->client()->postAccessibilityNotificationNew(WebAccessibilityObject(obj), toAXNotification(notification));
aboxhall 2013/08/07 15:58:10 Should this have a TODO to remove the duplication
dmazzoni 2013/08/07 16:23:53 Sure.
+ }
}
String ChromeClientImpl::acceptLanguages()

Powered by Google App Engine
This is Rietveld 408576698