Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Unified Diff: Source/testing/runner/WebTestProxy.cpp

Issue 22331005: Clean up accessibility enums for use in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update failing tests, add one missing role Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/testing/runner/WebTestProxy.cpp
diff --git a/Source/testing/runner/WebTestProxy.cpp b/Source/testing/runner/WebTestProxy.cpp
index c98315e82123c8614ff5abd9418ceb9e535bc7e0..de4ca084db39b71ee7536a674ffca3599f67d7d1 100644
--- a/Source/testing/runner/WebTestProxy.cpp
+++ b/Source/testing/runner/WebTestProxy.cpp
@@ -49,7 +49,7 @@
#include "public/testing/WebTestDelegate.h"
#include "public/testing/WebTestInterfaces.h"
#include "public/testing/WebTestRunner.h"
-#include "public/web/WebAccessibilityNotification.h"
+#include "public/web/WebAXTypes.h"
#include "public/web/WebAccessibilityObject.h"
#include "public/web/WebCachedURLRequest.h"
#include "public/web/WebConsoleMessage.h"
@@ -818,83 +818,101 @@ void WebTestProxyBase::didAutoResize(const WebSize&)
invalidateAll();
}
-void WebTestProxyBase::postAccessibilityNotification(const WebKit::WebAccessibilityObject& obj, WebKit::WebAccessibilityNotification notification)
+void WebTestProxyBase::postAccessibilityEvent(const WebKit::WebAccessibilityObject& obj, WebAXTypes::Event event)
{
- if (notification == WebKit::WebAccessibilityNotificationFocusedUIElementChanged)
+ if (event == WebAXTypes::Focus)
m_testInterfaces->accessibilityController()->setFocusedElement(obj);
- const char* notificationName;
- switch (notification) {
- case WebKit::WebAccessibilityNotificationActiveDescendantChanged:
- notificationName = "ActiveDescendantChanged";
+ const char* eventName;
+ switch (event) {
+ case WebAXTypes::ActiveDescendantChanged:
+ eventName = "ActiveDescendantChanged";
break;
- case WebKit::WebAccessibilityNotificationAutocorrectionOccured:
- notificationName = "AutocorrectionOccured";
+ case WebAXTypes::Alert:
+ eventName = "Alert";
break;
- case WebKit::WebAccessibilityNotificationCheckedStateChanged:
- notificationName = "CheckedStateChanged";
+ case WebAXTypes::AriaAttributeChanged:
+ eventName = "AriaAttributeChanged";
break;
- case WebKit::WebAccessibilityNotificationChildrenChanged:
- notificationName = "ChildrenChanged";
+ case WebAXTypes::AutocorrectionOccured:
+ eventName = "AutocorrectionOccured";
break;
- case WebKit::WebAccessibilityNotificationFocusedUIElementChanged:
- notificationName = "FocusedUIElementChanged";
+ case WebAXTypes::Blur:
+ eventName = "Blur";
break;
- case WebKit::WebAccessibilityNotificationLayoutComplete:
- notificationName = "LayoutComplete";
+ case WebAXTypes::CheckedStateChanged:
+ eventName = "CheckedStateChanged";
break;
- case WebKit::WebAccessibilityNotificationLoadComplete:
- notificationName = "LoadComplete";
+ case WebAXTypes::ChildrenChanged:
+ eventName = "ChildrenChanged";
break;
- case WebKit::WebAccessibilityNotificationSelectedChildrenChanged:
- notificationName = "SelectedChildrenChanged";
+ case WebAXTypes::Focus:
+ eventName = "Focus";
break;
- case WebKit::WebAccessibilityNotificationSelectedTextChanged:
- notificationName = "SelectedTextChanged";
+ case WebAXTypes::Hide:
+ eventName = "Hide";
break;
- case WebKit::WebAccessibilityNotificationValueChanged:
- notificationName = "ValueChanged";
+ case WebAXTypes::InvalidStatusChanged:
+ eventName = "InvalidStatusChanged";
break;
- case WebKit::WebAccessibilityNotificationScrolledToAnchor:
- notificationName = "ScrolledToAnchor";
+ case WebAXTypes::LayoutComplete:
+ eventName = "LayoutComplete";
break;
- case WebKit::WebAccessibilityNotificationLiveRegionChanged:
- notificationName = "LiveRegionChanged";
+ case WebAXTypes::LiveRegionChanged:
+ eventName = "LiveRegionChanged";
break;
- case WebKit::WebAccessibilityNotificationMenuListItemSelected:
- notificationName = "MenuListItemSelected";
+ case WebAXTypes::LoadComplete:
+ eventName = "LoadComplete";
break;
- case WebKit::WebAccessibilityNotificationMenuListValueChanged:
- notificationName = "MenuListValueChanged";
+ case WebAXTypes::LocationChanged:
+ eventName = "LocationChanged";
break;
- case WebKit::WebAccessibilityNotificationRowCountChanged:
- notificationName = "RowCountChanged";
+ case WebAXTypes::MenuListItemSelected:
+ eventName = "MenuListItemSelected";
break;
- case WebKit::WebAccessibilityNotificationRowCollapsed:
- notificationName = "RowCollapsed";
+ case WebAXTypes::MenuListValueChanged:
+ eventName = "MenuListValueChanged";
break;
- case WebKit::WebAccessibilityNotificationRowExpanded:
- notificationName = "RowExpanded";
+ case WebAXTypes::RowCollapsed:
+ eventName = "RowCollapsed";
break;
- case WebKit::WebAccessibilityNotificationInvalidStatusChanged:
- notificationName = "InvalidStatusChanged";
+ case WebAXTypes::RowCountChanged:
+ eventName = "RowCountChanged";
break;
- case WebKit::WebAccessibilityNotificationTextChanged:
- notificationName = "TextChanged";
+ case WebAXTypes::RowExpanded:
+ eventName = "RowExpanded";
break;
- case WebKit::WebAccessibilityNotificationAriaAttributeChanged:
- notificationName = "AriaAttributeChanged";
+ case WebAXTypes::ScrolledToAnchor:
+ eventName = "ScrolledToAnchor";
break;
- default:
- notificationName = "UnknownNotification";
+ case WebAXTypes::SelectedChildrenChanged:
+ eventName = "SelectedChildrenChanged";
+ break;
+ case WebAXTypes::SelectedTextChanged:
+ eventName = "SelectedTextChanged";
+ break;
+ case WebAXTypes::Show:
+ eventName = "Show";
+ break;
+ case WebAXTypes::TextChanged:
+ eventName = "TextChanged";
+ break;
+ case WebAXTypes::TextInserted:
+ eventName = "TextInserted";
+ break;
+ case WebAXTypes::TextRemoved:
+ eventName = "TextRemoved";
+ break;
+ case WebAXTypes::ValueChanged:
+ eventName = "ValueChanged";
break;
}
- m_testInterfaces->accessibilityController()->notificationReceived(obj, notificationName);
+ m_testInterfaces->accessibilityController()->notificationReceived(obj, eventName);
if (m_testInterfaces->accessibilityController()->shouldLogAccessibilityEvents()) {
string message("AccessibilityNotification - ");
- message += notificationName;
+ message += eventName;
WebKit::WebNode node = obj.node();
if (!node.isNull() && node.isElementNode()) {

Powered by Google App Engine
This is Rietveld 408576698